"Let them roll" I guess is a bad choice of words - I didn't mean to say "give them permission to roll". I meant, if they're searching, then they're "doing it" and should roll, so "have" them roll, not "let" them.
So, from what I understand, if they're actively searching for the trap, they'll get to roll Discern Realities. If they spring the trap, then they Defy Danger. Is there any circumstance where a Defy Danger roll is not granted due to the fiction? If so, what's an example that would give the GM a golden opportunity to hit them with a trap hard move?
I could maybe see Spout Lore being used if the player says something like "Have I heard of any legends of this place having lots of traps?" Otherwise, how could that Move apply to finding traps?
If the players describe an action that would discover a trap, they don't need to roll. That makes sense. If the player says "I poke the statue's shield with my ten foot pole" and that was the trap trigger, then boom, done. They find the trap and probably lose the pole. No roll needed.
I kind of agree with the statement that a secret undiscovered may as well not have existed, but I'm not so sure I totally agree the entire comment. Are you literally suggesting that if the PCs enter a room and ask if there's a secret door there, they should just find it automatically? That doesn't follow the fiction. You'd have to say "How do you look for a possible secret door?" and then they'd roll to discern it or they'd describe their character looking in the dead-on correct place and discover it without a roll.